1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/userdat.c

    From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, January 15, 2025 20:09:08
    https://gitlab.synchro.net/main/sbbs/-/commit/46cd7bbc3caea731da4075b9
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix parsing of field-separated birthdate strings with 4-digit year

    ... which is the format expected/required when entering or editing birthdates in the terminal server. So this is a pretty embarassingly bad bug introduced just before the v3.20b release to fix a less-severe bug with ecWeb new user registration (still) writing 2-digit years to the user.birthdate field. :-(

    Fix for issue #863

    I considerd making these get_birthdate field functions more tolerant of less strictly formatted strings (e.g. single-digit month or day), but decided to keep this change to just a fix for the issue at hand. These functions could be more robust to handle more variance in user/script input.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, January 19, 2025 22:45:36
    https://gitlab.synchro.net/main/sbbs/-/commit/046a7e535d163bfc99deb4c8
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Zero-length string is not a valid real name.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, February 03, 2025 11:25:22
    https://gitlab.synchro.net/main/sbbs/-/commit/1677e74966d6449e108ec464
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix ERROR 2 (...) in putnode.cpp ... opening "node.exb"

    Need the O_CREAT mode flag.

    Broken with commit d116f3622: I started using opennodeext() (created 5 years ago with commit 710bb23c1bd) rather than nopen(), and I didn't realize that opennodeext() was not including O_CREAT.

    Once the ctrl/node.exb was created (by anything), this error wouldn't happen. And it'd only be an issues for systems with text.dat's that included custom node status (NodeAction*) strings. Good catch Nelgin!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, April 11, 2025 18:13:56
    https://gitlab.synchro.net/main/sbbs/-/commit/02021bb18021c5d9d3da6e65
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Move check_pass() nearer the other check_* functions

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thursday, August 07, 2025 22:32:51
    https://gitlab.synchro.net/main/sbbs/-/commit/8e4a5c7fbabc68de3094c18f
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Add some comments to clarify difference between getbirthdstr and format_birth

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Saturday, August 09, 2025 19:12:38
    https://gitlab.synchro.net/main/sbbs/-/commit/c2805c6babbed02117e84852
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    User the laston date (rather than the last logon date/time) to reset stats

    (daily stat fields, logons/posts/emails/etc per day)

    This behavior was changed (broken) in commit ed00ed77

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Saturday, August 09, 2025 22:27:00
    https://gitlab.synchro.net/main/sbbs/-/commit/5e4076dbf2c128c98fa31f47
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Eliminate the (now) unnecessary ushort range checking

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, August 10, 2025 15:16:51
    https://gitlab.synchro.net/main/sbbs/-/commit/7a66d7f639788ba50797f943
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Resolve CID 583942 with a typecast

    Will need to switch to 64-bit time_t everywhere by 2038. We only maintain 32-bit time_t support (via time32_t) for Borland C++ compatibility.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, August 10, 2025 21:40:43
    https://gitlab.synchro.net/main/sbbs/-/commit/27cbebcb9ac75ff1f51a5ef2
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    There are actually 8 user fields that reset/zeroed daily, so check them all

    This is really just an optimization (I think), so we don't call time() for every parse/getuserdat() call, but only when the user has a non-zero daily reset field.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, August 11, 2025 15:51:59
    https://gitlab.synchro.net/main/sbbs/-/commit/bd9719d8df4a918ee1667d5a
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Add a user.level valid value range check to resetdailyuserdat()

    ... just in case we're called with an uninitialized user struct.

    Related to CID 583999

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, September 14, 2025 19:48:26
    https://gitlab.synchro.net/main/sbbs/-/commit/869dac47e01978f4e7f20fb5
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix inverted "GUEST" ARS keyword logic bug

    introduced in commit 661f5084fca81a01

    Fixes issue #975

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, December 17, 2025 15:49:56
    https://gitlab.synchro.net/main/sbbs/-/commit/2f7623fe054d6c2b9c1e41ec
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Do some error checking in logoutuserdat()

    (i.e. user.tab open/lock/read/write failures)

    I suspect this function has been failing on Vertrauen under heavy (Guest login/out) load, but there was no actual error reporting from this function which opens, locks, read and writes the user.tab file 4 times (!) for every user logout.

    Ideally:
    - this function would return more error details than simply success/failure
    - this function would only open/lock/read/write the user.tab file only once

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, December 17, 2025 19:09:19
    https://gitlab.synchro.net/main/sbbs/-/commit/5ccd9e8ccc6fd0158c7228b6
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix bug in subtract_cdt() handling free credit roll-under to regular credits

    Bug introduced in commit 8deac23222b3a3db (copy/paste/typo)

    Caught during manual code review.

    When a user has any amount of free credits, but the amount being subtracted
    was greater than their free credits available, the underflow was supposed to
    be deducted from their regular credits. Instead, the underflow was (attempted) to be deducted from their free credits, which were alreay zeroed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, December 20, 2025 04:34:42
    https://gitlab.synchro.net/main/sbbs/-/commit/a12a964a5ffbf5ab30e0fd8d
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Better user name/alias validity checking check_name() and check_realname()

    - detect/reject strings with control characters
    - detect/reject strings with non-ASCII character
    (when configured to do so by the sysop)

    Since the newuser.cpp already disallows this illegal input for new user values this likely only really makes a difference for any JS code that uses system.check_name() or system.check_realname() which is probably none.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, December 20, 2025 04:34:42
    https://gitlab.synchro.net/main/sbbs/-/commit/93cefd0e8f0a54e2711b8ae8
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    check_realname() now rejects 0xff char and names from name.can file

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, January 02, 2026 21:28:56
    https://gitlab.synchro.net/main/sbbs/-/commit/83a11c0359921d21e7b3b14e
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Add valid range enforcement in getbirthmonth() and getbirthday()

    This is required to pass the tests/user/birthdate.js tests/user/birthdate.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, January 03, 2026 00:14:09
    https://gitlab.synchro.net/main/sbbs/-/commit/2b773f32ee03f5b95fcb026a
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Reject blank strings as an invalid birthdate

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, January 03, 2026 04:45:04
    https://gitlab.synchro.net/main/sbbs/-/commit/d3a398d76a1a224c6254b7f5
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix the begin/end with white space checks in check_name and check_realname

    char is signed (usually)

    This was rejected names that ended in extended-ASCII chars (when allowed)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 13, 2026 22:16:37
    https://gitlab.synchro.net/main/sbbs/-/commit/fe0ef584fb420831e37e4174
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Address new Coverity issue

    CID 640988: Null pointer dereferences (FORWARD_NULL)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, January 15, 2026 16:38:13
    https://gitlab.synchro.net/main/sbbs/-/commit/abf06be881e9b986937c72de
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Fix "executing xtrn" node_activity() for multiple-concurrent logons (Guests)

    The name of the external program was pulled from the user record which in this case would always be the last program executed by (any) Guest. Instead, use
    the (slightly more ambiguous) node.aux field for external program being executed by Guest users or upon any failure to read the user record.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, March 11, 2026 00:14:47
    https://gitlab.synchro.net/main/sbbs/-/commit/d86d4d47d1ffc150ff9a95e6
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    A small optimization of user_can_access_grp/lib functions

    No need to check every sub/dir

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, March 11, 2026 02:35:19
    https://gitlab.synchro.net/main/sbbs/-/commit/a1b1612f3b68c1ecd5001bbf
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Remove unused variable

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, March 29, 2026 19:04:53
    https://gitlab.synchro.net/main/sbbs/-/commit/d8f673e82414c624b9d26d82
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    del_lastuser() truncates the user index (name.dat) file as well as data file

    Fix issue #1100, reported in IRC by plt

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, April 03, 2026 09:32:34
    https://gitlab.synchro.net/main/sbbs/-/commit/d44ddf8700f9782b7efe7cc2
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    Remove extraneous "external program" text from node status string

    When the xtrn prog code is valid, we include the program's full name in the status string and don't need the "external program" designation that was added in commit cc4fea1c6fd.

    Thanks to xbit for pointing out in IRC.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, May 06, 2026 19:41:53
    https://gitlab.synchro.net/main/sbbs/-/commit/6efdf3890e49237f9e099f01
    Modified Files:
    src/sbbs3/userdat.c
    Log Message:
    userdat: suppress LOCK false-positives in login* family (CIDs 631133, 631140, 631141, 631146)

    The link_list_t mutex is explicitly documented as recursive
    (link_list.h:99) — internal listCountNodes/listFreeNodes/listRemoveNode/ listPushNodeData calls re-acquire it safely. Coverity doesn't trace the recursive flag, so it flags every "outer-locked listX call" as a
    potential deadlock. Annotate each call site with a SUPPRESS plus a
    pointer to the documented invariant.

    CID 631145 (SLEEP-while-locked in loginBanned) was already mitigated
    in current source: listUnlock is called before the trashcan() call.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net