1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/telnets.c

    From Deucе@VERT to Git commit to main/sbbs/master on Friday, January 17, 2025 07:25:15
    https://gitlab.synchro.net/main/sbbs/-/commit/ad3236e3205dc25b9c3e3631
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    Set initial telnet modes in telnets

    Not sure how I missed this one.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, March 15, 2026 01:06:05
    https://gitlab.synchro.net/main/sbbs/-/commit/94c6ca35bbbfa4e4051b6e29
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    Add missing NULL checks on malloc() in telnets_connect()

    Same issue as ssh.c: conn_api.rd_buf and conn_api.wr_buf were
    allocated without NULL checks. The I/O threads would dereference
    NULL and crash on allocation failure.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, March 15, 2026 14:09:13
    https://gitlab.synchro.net/main/sbbs/-/commit/b97d08c93795dc03cc1f2ac7
    Modified Files:
    src/syncterm/telnets.c
    Log Message:
    Fix infinite loop and missing error checks in telnets.c

    - Input thread: change drain loop condition from "buffered < rd" to
    "bufsz > 0", and add !conn_api.terminate guard. The old condition
    compared against the last read size instead of remaining data,
    causing an infinite loop once bufsz drained to zero.
    - Add missing NULL checks on create_conn_buf() return values in
    telnets_connect(), matching all other connection providers.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net