1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/ripper.c

    From Deucе@VERT to Git commit to main/sbbs/master on Saturday, January 11, 2025 22:00:28
    https://gitlab.synchro.net/main/sbbs/-/commit/a98f8a44c3429b19fbef6803
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix a memory leak and an allowed out-of-bounds access.

    Thanks Coverity!

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Saturday, January 11, 2025 22:47:06
    https://gitlab.synchro.net/main/sbbs/-/commit/444fecaf4af203b773ca5833
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Add unreachable code

    Coverity thinks it can do the default case.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Saturday, January 18, 2025 13:08:33
    https://gitlab.synchro.net/main/sbbs/-/commit/a64e68143b0c192a44a840ff
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Do the lock assertion thing in ripper.c too.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Saturday, January 18, 2025 16:30:06
    https://gitlab.synchro.net/main/sbbs/-/commit/f41de9a1f41359c845de5371
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Now that vstat.vmem has more stuff, ripper needs to hack up more.

    Fixes assertion/crash in 91-column mode (used in LORD intro screens)

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, January 19, 2025 08:38:42
    https://gitlab.synchro.net/main/sbbs/-/commit/2aac6ec016aa3629c643e019
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Initialize the *new* memory, not the old stuff.

    Fixes various memory corruptions with RIP

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sunday, January 19, 2025 10:13:59
    https://gitlab.synchro.net/main/sbbs/-/commit/c464596b33610cc1683b69fd
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Work around what appears to be an integer promotion issue

    On an aarch64 Chromebook running gcc 12.2.0, these would wrap in
    weird ways causing vector fonts to be positioned incorrectly.

    It managed to say that (25 - -7) * 4 / 3 == -168
    This casting dance appears to resolve the issue.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wednesday, January 22, 2025 15:06:23
    https://gitlab.synchro.net/main/sbbs/-/commit/a97b1adad05bc8aec50278bf
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix possibly undefined value in ellipse.

    Top-right quadrant doesn't need a quadrant angle, the angle is what
    we want already.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wednesday, January 22, 2025 15:33:34
    https://gitlab.synchro.net/main/sbbs/-/commit/09b2157307bcfb080f0357a8
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Attempt to silence false positive warning.

    The warning suggests that x1 and y1 may be uninitialized in the i > 0
    block, but that's not really possible...

    It's too bad the warning doesn't clarify. It's also weird that the
    warning was in the draw_line() call and not in the lines above that (incorrectly) compared them with -1.

    Fix that check while we're here.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Monday, August 11, 2025 07:41:45
    https://gitlab.synchro.net/main/sbbs/-/commit/da21613cf1df6e208cf050a1
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    "Fix" CID 487623

    This "defect" is incorrect, but meh.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Monday, August 11, 2025 10:01:11
    https://gitlab.synchro.net/main/sbbs/-/commit/df3049a041766b8d6e2b132c
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Implement the RIP button explode flag

    Fix invert function, and take 50-100ms to "explode" the button.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Monday, August 11, 2025 10:07:34
    https://gitlab.synchro.net/main/sbbs/-/commit/bf88580858251dcb227a658c
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Cleanup last commit

    We don't need to save/restore all this stuff or leak memory.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Monday, August 11, 2025 12:12:16
    https://gitlab.synchro.net/main/sbbs/-/commit/07f235bb8481a2696857e937
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Handle RIP "ANSI extensions" even more better

    This change pulls in the entire sequence if it's available, which
    allows packet boundaries anywhere at all.

    More fixes for feature request 110.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tuesday, August 12, 2025 18:23:31
    https://gitlab.synchro.net/main/sbbs/-/commit/7714bcbe5262a9359abccaa9
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix typo

    The final char we're looking for here is !, not 1.
    Also, suppress a new Coverity false-positive (CID 487652) while we're
    here.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thursday, August 14, 2025 19:11:36
    https://gitlab.synchro.net/main/sbbs/-/commit/7a35f739a5182bb9c396c91b
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix the Coverity suppression maybe?

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net